cometindex: speedup by committing event changes in batches of 1000 #4854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of creating one transaction for each event we need to index, we instead only close this transaction every 1000 events (or when when we've caught up to the database). This gives about a 5x performance in catch up speed.
cronokirby
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
zbuc
reviewed
Sep 13, 2024
| @@ -179,7 +180,6 @@ impl Indexer { | |||
| relevant_events += 1; | |||
|
|
|||
| // Otherwise we have something to process. Make a dbtx | |||
zbuc
reviewed
Sep 13, 2024
| dbtx.commit().await?; | ||
| // Only commit in batches of <= 1000 events, for about a 5x performance increase when | ||
| // catching up. | ||
| if scanned_events % 1000 == 0 { |
There was a problem hiding this comment.
it seems possible to miss this if the while loop short circuits from the check at line 172, resulting in more than 1000 events being committed at once
There was a problem hiding this comment.
Switched to using the relevant_events as the metric, so that you commit every time you've processed 1000 relevant events, avoiding this issue.
cronokirby
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
7 tasks
conorsch
approved these changes
Sep 17, 2024
|
Requested changes have been made, so I'm approving and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating one transaction for each event we need to index, we instead only close this transaction every 1000 events (or when when we've caught up to the database).
This gives about a 5x performance in catch up speed.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: