-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publish useful packages #1305
publish useful packages #1305
Conversation
🦋 Changeset detectedLatest commit: 656db1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
high-level question, what's generally the difference between building with |
turbo is the task runner. the change is away from vite build lib mode. vite is primarily a website bundler and required a lot of configuration to build packages for publishing/consumption. lib mode is definitely an afterthought, and the plugins we needed to achieve things simply like external deps or typescript output were not well maintained - config didnt merge well, there were quirks to work around, etc tsup was something we looked at initially but was decided against. @VanishMax demonstrated a pretty concise use of it that seemed much nicer than our vite build configs. so this publishes the remainder of the packages that we should publish, applies package config that solves issues experienced by consumers, and uses tsup for all package builds, except wasm. wasm might be done with a bit more effort. |
tsc was also used directly for some builds, but there are internal deps like polyfills that we do want to inline. vite and tsup both use esbuild and rollup internally. |
this also avoids api-extractor which is very slow. api-extractor has benefits and features over rollup but we don't use them, and it lags behind typescript releases. we can enable it with a tsup flag if we choose. |
76b33ba
to
246521a
Compare
@turbocrime It is great to see how you took over the packages build configuration and perfected the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before merging, can we ensure that peer deps and tsup config are in-fact working? There were some issues last night that I'm not sure were resolved
tsup was not in fact working. turns out it mangles types due to some underlying esbuild issue, and that was what was causing peer issues and prevented services init. i ended up removing tsup. all package builds now use bare tsc. |
8c43178
to
aa074e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing against prax-wallet/prax#34 seems to work for me
use tsc for package builds, instead of vite lib mode.
build is much faster.
all remaining packages are correctly dependent, minimally chunked/bundled/polyfilled for target, and should be usable outside the repository.