Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump registry #1367

Merged
merged 2 commits into from
Jun 28, 2024
Merged

bump registry #1367

merged 2 commits into from
Jun 28, 2024

Conversation

Valentine1898
Copy link
Contributor

@Valentine1898 Valentine1898 commented Jun 28, 2024 •
edited
Loading

related to prax-wallet/prax#66

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b0e1db2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

grod220
grod220 approved these changes Jun 28, 2024
View reviewed changes
packages/storage/src/indexed-db/index.ts Outdated
Comment on lines 818 to 819
fetchStakingTokenId(): AssetId {
const registryClient = new ChainRegistryClient();
const registry = registryClient.get(this.chainId);
const stakingToken = registry.stakingAssetId;

return stakingToken;
return this.stakingTokenAssetId;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably fetch is the wrong name for this. Why don't we just make this a public variable so folks can grab it from the instance: https://github.com/penumbra-zone/web/pull/1367/files#diff-8298d111bc94531ec943d5f024a9ab57657ad28670caea51e3aa9eda88bf3954R83

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, if this is done, we should make storage a major version bump given we change the API in a breaking way

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grod220 will you be able to publish packages to npm?

@Valentine1898 Valentine1898 merged commit eae14f1 into main Jun 28, 2024
6 checks passed
@Valentine1898 Valentine1898 deleted the bump-registry branch June 28, 2024 09:22
@TalDerei TalDerei restored the bump-registry branch June 28, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grod220 grod220 grod220 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Valentine1898 @grod220