Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: fresh and existing wallets skip trial decryption #1707

Merged
merged 10 commits into from
Sep 3, 2024
Merged

sync: fresh and existing wallets skip trial decryption #1707

merged 10 commits into from
Sep 3, 2024

Conversation

TalDerei
Copy link
Contributor

@TalDerei TalDerei commented Aug 19, 2024 •
edited
Loading

references #1278 and related to prax-wallet/prax#164

@TalDerei TalDerei self-assigned this Aug 19, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 288b0b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@penumbra-zone/query Major
@penumbra-zone/types Major
@penumbra-zone/wasm Major
@penumbra-zone/services Major
minifront Patch
node-status Patch
@penumbra-zone/crypto-web Major
@penumbra-zone/storage Major
@repo/ui Patch
@penumbra-zone/perspective Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TalDerei TalDerei marked this pull request as draft August 19, 2024 04:25
@TalDerei TalDerei mentioned this pull request Aug 19, 2024
Merged
@TalDerei TalDerei requested a review from a team August 29, 2024 05:37
@TalDerei TalDerei marked this pull request as ready for review August 29, 2024 05:43
grod220
grod220 reviewed Aug 29, 2024
View reviewed changes
packages/query/src/block-processor.ts Outdated Show resolved Hide resolved
packages/query/src/block-processor.ts Outdated Show resolved Hide resolved
packages/query/src/block-processor.ts Outdated Show resolved Hide resolved
packages/query/src/block-processor.ts Outdated Show resolved Hide resolved
packages/types/src/block-processor.ts Outdated Show resolved Hide resolved
packages/wasm/crate/src/view_server.rs Show resolved Hide resolved
packages/wasm/crate/src/view_server.rs Outdated Show resolved Hide resolved
packages/wasm/crate/src/view_server.rs Show resolved Hide resolved
@TalDerei TalDerei changed the title sync: skip trial decryption for fresh wallets sync: fresh and existing wallets skip trial decryption Sep 2, 2024
grod220
grod220 approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One blocking comment. After addressing, feel free to merge.

.changeset/rude-camels-attack.md Outdated Show resolved Hide resolved
packages/query/src/helpers/skip-trial-decrypt.test.ts Show resolved Hide resolved
packages/query/src/helpers/skip-trial-decrypt.test.ts Show resolved Hide resolved
packages/wasm/crate/src/view_server.rs Show resolved Hide resolved
@TalDerei TalDerei merged commit e01d5f8 into main Sep 3, 2024
6 checks passed
@TalDerei TalDerei deleted the skip-trial-decryption branch September 3, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grod220 grod220 grod220 approved these changes

Assignees

@TalDerei TalDerei

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TalDerei @grod220