Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): #1713: WalletBalance UI component #1717

Merged
merged 6 commits into from
Aug 26, 2024
Merged

Conversation

VanishMax
Copy link
Contributor

@VanishMax VanishMax commented Aug 20, 2024

Closes #1713

A component that renders the BalancesResponse message type.

The result – https://penumbra-ui-preview--pr1717-feat-1713-wallet-ba-f79ntdv2.web.app/?path=/docs/ui-library-walletbalance--docs

image

@VanishMax VanishMax requested a review from a team August 20, 2024 13:45
@VanishMax VanishMax self-assigned this Aug 20, 2024
Copy link
Contributor

github-actions bot commented Aug 20, 2024

Visit the preview URL for this PR (updated for commit f0e419b):

https://penumbra-ui-preview--pr1717-feat-1713-wallet-ba-f79ntdv2.web.app

(expires Mon, 02 Sep 2024 08:35:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

Copy link
Collaborator

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

onClick={onClick}
>
<WalletIcon />
<ValueText detailTechnical>{account.account}</ValueText>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (blocking): this should have a # sign next to the account right?

@VanishMax VanishMax merged commit d01196a into main Aug 26, 2024
8 checks passed
@VanishMax VanishMax deleted the feat/#1713-wallet-balance branch August 26, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement <WalletBalance/> UI component
2 participants