Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "improve getter tools, don't export optional getters" #1767

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

turbocrime
Copy link
Contributor

Reverts #1574

didn't pass CI in main and causing errors in minifront

Copy link

changeset-bot bot commented Sep 4, 2024

⚠️ No Changeset found

Latest commit: 1153a05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Visit the preview URL for this PR (updated for commit 1153a05):

https://penumbra-ui-preview--pr1767-revert-1574-turbocri-f0j7fe7b.web.app

(expires Wed, 11 Sep 2024 16:05:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

@grod220
Copy link
Collaborator

grod220 commented Sep 4, 2024

Discussed offline to revert until bugs are identified

@grod220 grod220 merged commit 41c5146 into main Sep 4, 2024
3 checks passed
@grod220 grod220 deleted the revert-1574-turbocrime/getter-refactor branch September 4, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants