feat(ui): #1773, #1774: ValueInput and SwapInput
#1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…selector-ui-component
…selector-ui-component
VanishMax
changed the base branch from
main
to
1714-finish-the-assetselector-ui-component
|
Visit the preview URL for this PR (updated for commit 5173bcb): https://penumbra-ui-preview--pr1775-feat-1773-value-inp-ma6p3rle.web.app (expires Thu, 19 Sep 2024 10:21:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1 |
TalDerei
approved these changes
Sep 11, 2024
|
@TalDerei Do you mean the arrows up-down in the number input? We can hide them but I don't see the necessity – it generally improves the a11y |
It's a minor nit, but I personally feel like that component feels outdated and actually not that particularly useful when I was interacting with the Storybook. I'm in favor of removing it. |
Base automatically changed from
1714-finish-the-assetselector-ui-component
to
main
September 12, 2024 10:16
# Conflicts: # packages/ui/src/AssetSelector/index.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1773
Closes #1774
Closes #1776
ValueInput: https://penumbra-ui-preview--pr1775-feat-1773-value-inp-ma6p3rle.web.app/?path=/docs/ui-library-valueinput--docsSwapInput: https://penumbra-ui-preview--pr1775-feat-1773-value-inp-ma6p3rle.web.app/?path=/docs/ui-library-swapinput--docsAlso it updates the styles of
TextInputandButtoncomponents to match the latest designs according to #1776.