Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui, minifront): v2 nav style fixes #1800

Merged
merged 6 commits into from
Sep 25, 2024
Merged

fix(ui, minifront): v2 nav style fixes #1800

merged 6 commits into from
Sep 25, 2024

Conversation

VanishMax
Copy link
Contributor

  • Adds a temporary zIndex prop to the Dialog component. It is only needed for minifront v1 and must be removed when we stop supporting the v1.
  • Improves the styles of the v2 sync bar and popover like this (notice the beautiful background):
image image

@VanishMax VanishMax requested a review from a team September 20, 2024 11:20
@VanishMax VanishMax self-assigned this Sep 20, 2024
Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: cf27233

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
minifront Patch
@penumbra-zone/ui Patch
node-status Patch
@repo/tailwind-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@VanishMax VanishMax marked this pull request as ready for review September 20, 2024 11:21
Copy link
Contributor

github-actions bot commented Sep 20, 2024

Visit the preview URL for this PR (updated for commit cf27233):

https://penumbra-ui-preview--pr1800-fix-v2-styles-rifiki3s.web.app

(expires Wed, 02 Oct 2024 13:58:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

Copy link
Collaborator

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	packages/ui/src/Button/index.tsx
#	packages/ui/src/utils/popover.ts
@VanishMax VanishMax merged commit 4295109 into main Sep 25, 2024
8 checks passed
@VanishMax VanishMax deleted the fix/v2-styles branch September 25, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants