Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slim Density #1847

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Slim Density #1847

wants to merge 2 commits into from

Conversation

JasonMHasperhoven
Copy link
Contributor

For the dex-explorer we need to support another variation of density that's smaller than compact: slim.

This PR changes the API slightly for the Density component. Instead of passing compact or sparse as prop directly, it now needs to be passed as value for the density prop.

It also adds the slim variation to the table cell css.

Copy link

changeset-bot bot commented Oct 4, 2024

🦋 Changeset detected

Latest commit: f964812

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
minifront Minor
@penumbra-zone/ui Minor
node-status Patch
@repo/tailwind-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Visit the preview URL for this PR (updated for commit f964812):

https://penumbra-ui-preview--pr1847-density-slim-cwze26y6.web.app

(expires Fri, 11 Oct 2024 15:39:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

@grod220
Copy link
Collaborator

grod220 commented Oct 4, 2024

Just checking, have you synced with @smmhrdmn on the proposed density update?

@smmhrdmn
Copy link

smmhrdmn commented Oct 4, 2024

@JasonMHasperhoven is this a response to just the tables, or a broader issue? if it's just the tables, i've been refining them and have some updates that should address this. in general, i think it makes more sense to refine our existing props instead of adding new ones, since many of the components won't be affected by the new prop. but obviously im open to whatever addresses the needs more directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants