Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Text props #1848

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Add Text props #1848

merged 1 commit into from
Oct 14, 2024

Conversation

JasonMHasperhoven
Copy link
Contributor

Adding additional props that are common and widely used to the Text component.

If you can think of more props that would be good to add, please mention it here.

Copy link

changeset-bot bot commented Oct 4, 2024

⚠️ No Changeset found

Latest commit: 90ad713

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

align,
decoration,
transform,
break: breakProp,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break is a reserved js word

@JasonMHasperhoven JasonMHasperhoven requested a review from a team October 4, 2024 16:03
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Visit the preview URL for this PR (updated for commit 90ad713):

https://penumbra-ui-preview--pr1848-text-props-z7jooayl.web.app

(expires Fri, 11 Oct 2024 16:05:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

Copy link
Contributor

@VanishMax VanishMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to me!

@JasonMHasperhoven JasonMHasperhoven merged commit a8d8c77 into main Oct 14, 2024
8 checks passed
@JasonMHasperhoven JasonMHasperhoven deleted the text-props branch October 14, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants