Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add RadioGroup and RadioItem to the Dialog component #1852

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

VanishMax
Copy link
Contributor

@VanishMax VanishMax commented Oct 11, 2024

Relates to #1811 – the UI improvement make a good-looking wallet selection.

In action: https://penumbra-ui-preview--pr1852-feat-dialog-radio-gr-z2fowoz6.web.app/?path=/docs/ui-library-dialog--docs

This PR moves the ListItem component that previously belonged to AssetSelector to the DialogComponent. Now, the following API is allowed:

<Dialog>
  <Dialog.Trigger asChild>
    <Button>Open dialog</Button>
  </Dialog.Trigger>

  <Dialog.Content title='Select wallet'>
    <Dialog.RadioGroup>
      <Column>
        <Dialog.RadioItem value='1' title='Wallet 1' />
        <Dialog.RadioItem value='2' title='Wallet 2' />
        <Dialog.RadioItem value='3' title='Wallet 3' />
      </Column>
    </Dialog.RadioGroup>
  </Dialog.Content>
</Dialog>
image

@VanishMax VanishMax requested a review from a team October 11, 2024 11:32
@VanishMax VanishMax self-assigned this Oct 11, 2024
Copy link

changeset-bot bot commented Oct 11, 2024

🦋 Changeset detected

Latest commit: a91a959

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@penumbra-zone/ui Minor
minifront Patch
node-status Patch
@repo/tailwind-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 11, 2024

Visit the preview URL for this PR (updated for commit a91a959):

https://penumbra-ui-preview--pr1852-feat-dialog-radio-gr-z2fowoz6.web.app

(expires Fri, 18 Oct 2024 11:36:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

Copy link
Collaborator

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@VanishMax VanishMax merged commit deb04f5 into main Oct 11, 2024
8 checks passed
@VanishMax VanishMax deleted the feat/dialog-radio-group branch October 11, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants