Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

위젯에서 인라인 스타일 전체 제거 #1499

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

devunt
Copy link
Member

@devunt devunt commented Nov 21, 2024

  • custom element 이용 안 하고 shadow dom 직접 조작함
  • svelte의 style: directive 대신 js의 cssom 이용함
  • svelte css module을 constructible style sheet로 변환하는 vite 플러그인 구현함

Copy link

graphite-app bot commented Nov 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “:rocket:” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

devunt commented Nov 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@devunt devunt force-pushed the feature/no-inline-styles-for-widget branch from 5e510cf to 4962402 Compare November 22, 2024 03:48
@devunt devunt added the 🚀 #가보자고 label Nov 22, 2024
Copy link
Member Author

devunt commented Nov 22, 2024

Merge activity

  • Nov 21, 10:50 PM EST: The merge label ':rocket:' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 21, 10:50 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 21, 10:53 PM EST: A user merged this pull request with the Graphite merge queue.

- custom element 이용 안 하고 shadow dom 직접 조작함
- svelte의 `style:` directive 대신 js의 cssom 이용함
- svelte css module을 constructible style sheet로 변환하는 vite 플러그인 구현함
@devunt devunt force-pushed the feature/no-inline-styles-for-widget branch from 4962402 to f4e6bcc Compare November 22, 2024 03:51
@graphite-app graphite-app bot merged commit f4e6bcc into main Nov 22, 2024
7 checks passed
@graphite-app graphite-app bot deleted the feature/no-inline-styles-for-widget branch November 22, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 #가보자고
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant