-
Notifications
You must be signed in to change notification settings - Fork 4
Add Docker + GitHub Actions + Update deps & docs #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker + GitHub Actions + Update deps & docs #2
Conversation
- Docker first approach : use an existing signal-cli config from host (or from docker volume) - Switch to .env for config instead of config.js : it's more suitable for docker and it's versatile (works both in docker and locally)
That was painful, but it is worth it!
- Remove multistage build now that libsignal is available for aarch64 - Update base node image 18->22 - Update openjdk 17->21 (signal-cli requirement) - Signal-cli should be 0.13.12-r0 at the time of commit - Add docker compose prod override (amd64+arm64). Docker prod image name is set in .env so everyone can choose their registry
- Based on latest "Publish Docker Container" GitHub Actions workflow template - Update multiarch workflow steps from docs too (https://docs.docker.com/build/ci/github-actions/multi-platform/)
Otherwise you'll get "DBusError: The name org.asamk.Signal was not provided by any .service files"
Hello @theblackhole. Wow, that's a lot of work. I'm no longer using this project and don't have a way to test your changes. I'm uncertain on what to do. Should I just merge your PR, or would you want to take ownership of the project? |
Hello @peoro, Hum I don't know either. If you don't want to/can't maintain the repo anymore, rather than transferring full ownership to me I see 3 options:
I think we can start with option 1 or 2 and see later for 3 if it's worth it. |
I sent you an invitation to become a contributor to the project. I'll be happy to further change things whenever you or others feel the need. |
Thanks. I'll merge this then :) |
Changes made with this Pull Request:
TL;DR: ➕ Docker ➕ GitHub Actions ➡️
config.js
→.env
🔄 Dependencies ✍️ Readme.env
:.env
file in order to both work locally and with Docker. This is also easier to work with (overrides etc) than a .js filedbus-next
seems abandonned, last release is from 2021. Maybe starting to look for an alternative would be wise.