Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input schema fails to validate #521

Closed
donaldcampbelljr opened this issue Aug 29, 2024 · 1 comment
Closed

input schema fails to validate #521

donaldcampbelljr opened this issue Aug 29, 2024 · 1 comment

Comments

@donaldcampbelljr
Copy link
Contributor

Using the generic input schema in examples from hello_looper, I get validation issues:

  File "/home/drc/GITHUB/looper/master/looper/venv/lib/python3.10/site-packages/eido/validation.py", line 56, in _validate_object
    raise EidoValidationError("Validation failed", errors_by_type)
eido.exceptions.EidoValidationError: EidoValidationError (Validation failed): {"'pipeline_name' is a required property": [{'type': "'pipeline_name' is a required property", 'message': "'pipeline_name' is a required property on instance project", 'sample_name': 'project'}], "'pipeline_type' is a required property": [{'type': "'pipeline_type' is a required property", 'message': "'pipeline_type' is a required property on instance project", 'sample_name': 'project'}], "'command_template' is a required property": [{'type': "'command_template' is a required property", 'message': "'command_template' is a required property on instance project", 'sample_name': 'project'}]}

Piface is simply pointing to the generic one provided by looper:

pipeline_name: count_lines
output_schema: pipestat_output_schema.yaml
input_schema: /home/drc/GITHUB/looper/master/looper/looper/schemas/pipeline_interface_schema_generic.yaml
sample_interface:
  command_template: >
    python3 {looper.piface_dir}/count_lines.py {sample.file_path} {sample.sample_name} {pipestat.results_file} {pipestat.output_schema}

Probably related to:
pepkit/eido#64
databio/bbconf#20

@donaldcampbelljr
Copy link
Contributor Author

Oh, using a generic PEP schema as input schema works fine: https://schema.databio.org/pep/2.1.0.yaml

Looks like looper validates Pifaces within the PIpelineInterface class and does not rely on Eido for that specifically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant