Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sizing keyword is not working correctly #524

Open
nsheff opened this issue Sep 19, 2024 · 1 comment
Open

sizing keyword is not working correctly #524

nsheff opened this issue Sep 19, 2024 · 1 comment
Labels

Comments

@nsheff
Copy link
Contributor

nsheff commented Sep 19, 2024

Right now, looper is using tangible to determine input file size, not sizing.

@nsheff nsheff added the bug label Sep 19, 2024
@donaldcampbelljr
Copy link
Contributor

This is happening in Eido here:
https://github.com/pepkit/eido/blob/87eead537180db57176a56e5c6e8523fdbdfd0b5/eido/inspection.py#L72-L93

It appears to be using both the sizing and the tangible attributes to determine input file size by collecting all files and then calculating the input_file_size from the sum of all input files. In the hello_looper example, we use the same file path for each of these, so the set of files to determine size will contain only that single supplied file path. Thus, only one file is calculated for this input_file_size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants