Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toggling derived attributes in looper summarize results. #82

Open
nsheff opened this issue Nov 27, 2018 · 3 comments
Open

toggling derived attributes in looper summarize results. #82

nsheff opened this issue Nov 27, 2018 · 3 comments

Comments

@nsheff
Copy link
Contributor

nsheff commented Nov 27, 2018

It would be nice if the looper summary results page could toggle between showing derived attribute keys and actual derived attributes.

For any attributes listed as derived_attributes, the Sample object will have an additional attribute for the key. For example, if the attribute were color, it would be an attribute called color_key.

We could use this along with CSS to toggle which is displayed for that attribute, the key or the value.

@nsheff nsheff added this to the 0.14 milestone Mar 24, 2020
@nsheff nsheff modified the milestones: 1.4.0, 1.6.0 Feb 16, 2023
@donaldcampbelljr donaldcampbelljr modified the milestones: 1.6.0, 1.7.0 Nov 7, 2023
@donaldcampbelljr
Copy link
Contributor

HTML report generation has been moved to pipestat summarize. Recently,we added passing looper sample objects to pipestat summarize to add attributes from the PEP to the generated report. These derived attriubtes live on the same sample object:
image

Therefore, they can be accessed and used for the above request.

donaldcampbelljr added a commit to pepkit/pipestat that referenced this issue Jan 11, 2024
@donaldcampbelljr
Copy link
Contributor

donaldcampbelljr commented Jan 11, 2024

Some initial exploratory work placing these items in their own section below the main sample table:
image

I will change it to a better looking table that contains:

  • attributes to be derived,
  • source key and source value corresponding to each attribute

I will also see if I can enable toggling of that section.

Currently, the derived attributes are reported in the sample table.

@donaldcampbelljr
Copy link
Contributor

After discussion:

  • The above POC is not desired because we want to see where each derived attribute is actually sourced from. In the above example, this is trivial because every sample's read1 comes from R1, but that may not be the case. For example, Read1 for one sample might come from R1 and another sample might from from Ex1. Therefore adding the above table is not helpful.
  • To do this properly, adding a toggle to switch the derived attribute with the source key will require a bit more work editing the index html template as well as modifying css and javascript. Therefore, we have decided to make this low priority until there is appetite/ability to do more front-end work and possibly re-do the report entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

No branches or pull requests

3 participants