Fix Bot Not trading items less than ignore rate #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if your bots inventory has a item that's price is less than the site's ignore rate, it will get its value set to zero just like it would for the user. This fix lets users trade for an item from the bot that is worth less than the ignore rate while still not allowing the user to trade the site items that have a price less than your ignore rate. For example: The bot has a item worth .49 cents, your ignore rate is set to ignore all skins less than .50 cents. When a user would try to trade for the skin that is worth less than the ignore rate they would get the error "Could not get a price for item(s). Trade has been cancelled". This is because the bot was using the same getprice function as the user would and it would set the price too zero because it is less than the ignore rate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if your bots inventory has a item that's price is less than the site's ignore rate, it will get its value set to zero just like it would for the user. This fix lets users trade for an item from the bot that is worth less than the ignore rate while still not allowing the user to trade the site items that have a price less than your ignore rate.
For example:
The bot has a item worth .49 cents, your ignore rate is set to ignore all skins less than .50 cents. When a user would try to trade for the skin that is worth less than the ignore rate they would get the error "Could not get a price for item(s). Trade has been cancelled". This is because the bot was using the same getprice function as the user and it would set the price to zero because it is less than the ignore rate.