-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Fingerprint() to make it work correctly with MAX_EXECUTION_TIME statement #63
base: PMM-2.0
Are you sure you want to change the base?
Fix Fingerprint() to make it work correctly with MAX_EXECUTION_TIME statement #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution 👍
Just to be clear |
Yes, that's fine - it's the project default branch. |
Is there anything further needed from my side to get the PR merged? |
Nothing more, it's ready for testing as is. Unfortunately, we have to wait until we release our next product version, which is what prevents us from merging this PR sooner. Apologies for that and thanks a lot! |
Got it. |
Any hints about when the next product version will be/planned to be released would be very much appreciated :)! |
https://perconadev.atlassian.net/browse/PMM-13757
Function
func Fingerprint(q string) string
does not work correctly withSELECT /*+ MAX_EXECUTION_TIME(<number>) */
statement.For queries where column names are wrapped into backticks ``,
MAX_EXECUTION_TIME(123)
statement is preserved with a number. The number is not replaced by ?.For queries where column names are not wrapped into backticks, it works correctly and does not copy
MAX_EXECUTION_TIME(<number>)
to a fingerprint at all.This PR:
Fingerprint()
function work correctly withMAX_EXECUTION_TIME()