feat: Prevent SEGFAULT in Cast operations #1197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cast operations are unsafe in case of an incomplete configuration and can end up in SEGFAULT.
This PR fixes that by introducing basic checks (Object is defined) and returning an error if that is not the case.
This PR also adds a test for the S3 case to ensure that this functionality works as expected.
Moreover, as there is a default value for the region, the
Region
field can be made optional withomitempty
and the correct value will be picked automatically.BEFORE:
AFTER:
Referred in the bug tracker as PBM-1619 here