Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPG-375: Install pg_repack and postgis by default #857

Merged
merged 5 commits into from
Nov 8, 2023
Merged

K8SPG-375: Install pg_repack and postgis by default #857

merged 5 commits into from
Nov 8, 2023

Conversation

egegunes
Copy link
Contributor

@egegunes egegunes commented Oct 24, 2023

K8SPG-375 Powered by Pull Request Badge

@egegunes egegunes requested a review from hors October 24, 2023 07:02
@CLAassistant
Copy link

CLAassistant commented Nov 1, 2023

CLA assistant check
All committers have signed the CLA.

CGO_ENABLED=$CGO_ENABLED GOOS=$GOOS GOARCH=$GOARCH \
make local build

FROM redhat/ubi8-minimal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have use our postgres image as a base image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check it out @hors pls: 6e1c2a4

@@ -0,0 +1,11 @@
arg basever
FROM percona/percona-postgresql-operator:${basever}-postgres
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to be able to set percona or perconalab

RUN set -ex; \
curl -Lf -o /etc/pki/rpm-gpg/RPM-GPG-KEY-oracle https://yum.oracle.com/RPM-GPG-KEY-oracle-ol8; \
microdnf -y module disable postgresql; \
microdnf -y install percona-postgis33 percona-postgis33-client;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@inelpandzic are you sure that we should not add these lines:

EXPOSE 5432

ADD bin/postgres-gis /opt/crunchy/bin/postgres

ENTRYPOINT ["/opt/crunchy/bin/uid_postgres.sh"]

USER 26

CMD ["/opt/crunchy/bin/start.sh"]

Did you test it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll recheck it @hors , maybe you're right.

@hors hors self-requested a review November 8, 2023 11:52
@hors hors merged commit b53e523 into main Nov 8, 2023
@hors hors deleted the K8SPG-375 branch November 8, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants