Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change container port to match metrics-bind-address #265

Closed
wants to merge 1 commit into from

Conversation

kovaxur
Copy link

@kovaxur kovaxur commented Nov 27, 2023

The 'metrics' container port is now set to 60000, but the default value for the operator's metric endpoint is 8080:

  -metrics-bind-address string
        The address the metric endpoint binds to. (default ":8080")

Without changing to 8080, it is impossible to monitor the operator via Prometheus.

This could be further refined to allow the user to set a custom port for monitoring, but I think this is not important now.

@it-percona-cla
Copy link

it-percona-cla commented Nov 27, 2023

CLA assistant check
All committers have signed the CLA.

@hors hors requested a review from tplavcic November 27, 2023 14:30
@hors
Copy link
Collaborator

hors commented Nov 27, 2023

@kovaxur please sign CLA

@kovaxur
Copy link
Author

kovaxur commented Nov 27, 2023

@hors done, thanks

@egegunes
Copy link
Contributor

@kovaxur thank you for your contribution. there is another PR (#173) which implements the same things and additionally configures probes so we'll merge than one. I'm closing this one.

@egegunes egegunes closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants