Fix ingress for grpc. #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MostovykVlad
commented
Dec 19, 2023
MostovykVlad
commented
- Disable hardcode 443 port
- Add an annotation according to the topic in the forum: https://forums.percona.com/t/pmm-server-deployed-on-k8s-failed-to-establish-two-way-communication-channel/22708
MostovykVlad
requested review from
BupycHuk and
JiriCtvrtka
and removed request for
a team
|
|
BupycHuk
previously approved these changes
Dec 20, 2023
|
Hi @MostovykVlad, Thank you for the contribution, could you please sign CLA and bump helm chart version? |
|
Hello @BupycHuk, CLA signed, new commit added. Thank you! |
BupycHuk
approved these changes
Dec 20, 2023
JiriCtvrtka
approved these changes
Dec 20, 2023
gdubicki
pushed a commit
to gdubicki/percona-helm-charts
that referenced
this pull request
Jan 15, 2024
* Fix ingress for grpc. * Bump pmm chart version to 1.3.6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.