-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPSMDB-1042 - psmdb - release 1.16.0 and convert replsets from array to map #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spron-in
previously approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change. Much better user experience. Thank you @tplavcic !
tplavcic
changed the title
K8SPSMDB-1042 - psmdb-db - Allow overriding individual replica values
K8SPSMDB-1042 - psmdb-db - convert array to map for replsets
May 23, 2024
tplavcic
changed the title
K8SPSMDB-1042 - psmdb-db - convert array to map for replsets
K8SPSMDB-1042 - psmdb - release 1.16.0 and convert replsets from array to map
May 23, 2024
tplavcic
force-pushed
the
k8spsmdb-1042
branch
2 times, most recently
from
May 24, 2024 15:50
0fc6cf0
to
42e9414
Compare
ptankov
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This will break how the options for replica set are specified so it will be merged with
1.16.0
release.Change 1: Update psmdb-operator and psmdb-db charts for 1.16.0 release
Change 2: Convert array to map for replsets
Replica set array is converted to a map so it is more convenient for users to specify options, no need for quotes in command line and also the order in the array might change uncontrollably which makes it hard to use in automation tools which is not the case with a map.
Helm documentation on the best practices: https://helm.sh/docs/chart_best_practices/values/#:~:text=For%20this%20reason%2C%20it%27s%20often%20better%20to%20structure%20your%20values%20file%20using%20maps.
The name for a key which is used to hold the replica values (eg.
rs0
which is fixed for the first one) is not important and the.name
key will be used as a replica name, but if you omit the.name
then the key name will be used as a name.eg. if you specify:
the end result will be: