K8SPXC-1365 - pxc-operator - Fix watchNamespace #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptankov
previously approved these changes
Mar 15, 2024
tplavcic
force-pushed
the
K8SPXC-1365-watchnamespace
branch
from
38966fa
to
44323cf
Compare
ptankov
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we specify
watchNamespacewith multiple namespaces separated with commas namespace creation will fail (because it will try to create namespaceaaa, bbb) so now we do it in a loop for each specified namespace and only ifcreateNamespaceis set totrue.Default is now being changed to not create a namespace unless enabled.