K8SPG-527 - Fix pg-db cluster.yaml resources placeholder syntax error #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TAbhay
requested review from
hors,
tplavcic,
nmarukovich and
ptankov
as code owners
|
|
tplavcic
requested changes
Mar 18, 2024
|
@tplavcic Please review it. Thank you 🙂 |
tplavcic
changed the title
tplavcic
approved these changes
Mar 22, 2024
tplavcic
changed the title
|
@TAbhay Thank you very much for the contribution! It is now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While installing the pg-db cluster using helm, instance was not able to allocation resources.
Error:
client.go:134: [debug] creating 2 resource(s) error: installation failed: 1 error occurred: * perconapgcluster.pgv2.percona.com "pg-db" is invalid: [spec.instances[0].resources.limits.cpu: invalid value: "$instance.resourc": spec.instances[0].resources.limits.cpu in body should match '^(\+|-)?(([0-9]+(\.[0-9])?)|(\.[0-9]+))(([kmgtpe]i)|[numkmgtpe]|([ee](\+|.[0-9])?)|(\.[0-9]+))))?$', spec.instances[0].resources.limits.memory: invalid value: "$instance.resources.limits.memory": spec.instances.limits.memory in body should match '^(\+|-)?(([0-9]+(\.[0-9])?)|(\.[0-9]+))(([kmgtpe]i)|[numkmgtpe]|([ee](\+|-)?(([0-9]+(\.[0-9])?)|(\., spec.backups.pgbackrest.repos: required value]Reason: Placeholder syntax error in cluster.yaml of pg-db/charts/templates/cluster.yaml
Here, I have attached the screenshots for issue & fix.
Issue:
Fix: