fix argo diff in pvc template #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyriosGN0
requested review from
BupycHuk and
idoqo
and removed request for
a team
|
@tplavcic could you please have a look? |
tplavcic
previously approved these changes
Sep 17, 2024
|
@spron-in LGTM |
KyriosGN0
force-pushed
the
fix-argo-diff-pmm-chart
branch
from
13a2e04
to
d2d3ab4
Compare
tplavcic
previously approved these changes
Oct 22, 2024
Signed-off-by: AvivGuiser <[email protected]>
KyriosGN0
force-pushed
the
fix-argo-diff-pmm-chart
branch
from
a9bb15b
to
f5f0d80
Compare
Signed-off-by: AvivGuiser <[email protected]>
|
@tplavcic fixed the conflicts again. |
tplavcic
approved these changes
Nov 4, 2024
BupycHuk
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when deploying in argo the statefulset has a diff since we don't set the apiVersion and kind fields
fixes #358