Fix: replaced pxc-operator service name hardcode #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71g3pf4c3
requested review from
hors,
tplavcic,
nmarukovich,
ptankov,
jvpasinatto and
eleo007
as code owners
|
|
71g3pf4c3
force-pushed
the
fix-pxc-operator-service-name-hardcode
branch
from
8e6930c
to
a6c73b4
Compare
|
Thank you for the contribution! Please bump the chart version. |
Bumped version, happy to help! |
|
@jvpasinatto please consider merging. This bug potentially can break installations |
|
Hi @71g3pf4c3, sorry for the delay. I discussed this with my colleagues, and it seems pxc-operator will create a service with name "percona-xtradb-cluster-operator" either way, so with your PR we end up with 2 services. So, if you want to be able to specify the service name we need to change operator code. Could you please create a ticket for this functionality if thats what you desire here https://perconadev.atlassian.net/jira/software/c/projects/K8SPXC/boards/63? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #380
Fixed service name in metadata and labels