Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPS-317: Remove JSON usage #466

Merged
merged 5 commits into from
Jan 29, 2024
Merged

K8SPS-317: Remove JSON usage #466

merged 5 commits into from
Jan 29, 2024

Conversation

egegunes
Copy link
Contributor

@egegunes egegunes commented Oct 9, 2023

K8SPS-317 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
JSON usage causes memory leak. See this MySQL bug.

Solution:
Remove JSON usage from operator.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are the manifests (crd/bundle) regenerated if needed?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PS version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/L 100-499 lines label Oct 9, 2023
@hors hors changed the title remove JSON usage K8SPS-317 remove JSON usage Dec 19, 2023
@egegunes egegunes marked this pull request as ready for review January 15, 2024 09:02
@egegunes
Copy link
Contributor Author

let's wait #517 to be merged before this

@egegunes egegunes changed the title K8SPS-317 remove JSON usage K8SPS-317: Remove JSON usage Jan 15, 2024
@egegunes egegunes added this to the v0.7.0 milestone Jan 16, 2024
hors
hors previously approved these changes Jan 22, 2024
@hors hors self-requested a review January 24, 2024 11:25
@JNKPercona
Copy link
Collaborator

Test name Status
async-ignore-annotations passed
auto-config passed
config passed
config-router passed
demand-backup passed
gr-demand-backup passed
gr-demand-backup-haproxy passed
gr-haproxy passed
gr-ignore-annotations passed
gr-init-deploy passed
gr-one-pod passed
gr-recreate passed
gr-scaling passed
gr-self-healing passed
gr-tls-cert-manager passed
gr-users passed
haproxy passed
init-deploy passed
limits passed
monitoring passed
one-pod passed
operator-self-healing passed
recreate passed
scaling passed
service-per-pod passed
sidecars passed
smart-update passed
tls-cert-manager passed
users passed
version-service passed
We run 30 out of 30

commit: 2dd85c0
image: perconalab/percona-server-mysql-operator:PR-466-2dd85c0

@hors hors merged commit 22c1a35 into main Jan 29, 2024
7 checks passed
@hors hors deleted the K8SPS-317 branch January 29, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants