-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPS-331 - chore: migrate from kuttl to chainsaw #560
base: main
Are you sure you want to change the base?
Conversation
3f4db0a
to
97304d4
Compare
Ooops, i think i need to do something for jenkins 🤔 |
please check https://github.com/percona/percona-server-mysql-operator/blob/main/Jenkinsfile |
Thanks @hors ! How does chainsaw gets installed on jenkins ? |
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Found it. |
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
There's something i'm not getting here |
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
commit: 8c68083 |
@tplavcic let me know when i should resolve conflicts |
@eddycharly We have this problem: https://docs.cloudbees.com/docs/cloudbees-ci-kb/latest/client-and-managed-controllers/why-jenkinsfile-changes-are-not-reflected-in-pr-build |
@tplavcic got it ! Maybe we can have both kuttl and chainsaw first, then remove kuttl from jenkins, and finally remove kuttl tests ? I think in this order it should work 🤷 |
Hi @eddycharly ! FYI: Currently we are working on Is there a possibility to share a tool for migration? Can this tool be re-run simply/quickly if we have many test changes? Thank you very much for your work! |
@tplavcic i will work on this next week, thanks for the update. |
@eddycharly There are some discussions in the team about the direction for our E2E tests so I propose for the moment you don't spend more time on this PR until some decision is made. Thanks! |
Hi @tplavcic thanks for letting me know ! |
This PR migrates e2e tests from kuttl to chainsaw.
Chainsaw was created because kuttl stopped to be actively maintained (it's actually a single maintainer now).
We are also solving most of the kuttl limitations that exist today and wrote a command to automatically migrate from kuttl to chainsaw. It supercharges e2e tests with better logs, config maps assertions, assertions trees and many more things 💪
This is a relatively young project but it has already been adopted by a couple of e2e tests heavy projects (kyverno, keptn, fairwinds rbac-manager, grafana-operator, redis-operator and others).
To give more context, you can see similar PRs at:
Sadly, kuttl haven't done a release since jan 2023.
Here you can find a good video showcasing chainsaw: https://www.youtube.com/watch?v=Ejof-wtAdQM&ab_channel=CamilaMacedo
To make things more concrete, there are a couple of issues in this repo, a few files are not valid and kuttl doesn't complain because unmarshalling is not strict so the non-valid fields are simply ignored. This is a problem because the behaviour of the tests is not the expected one.
If you need more infos 👇