Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPS-359: Fix rebooting cluster if it's partially online #725

Merged
merged 4 commits into from
Aug 19, 2024

fix cw-rbac

75bb02d
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

K8SPS-359: Fix rebooting cluster if it's partially online #725

fix cw-rbac
75bb02d
Select commit
Loading
Failed to load commit list.
GitHub Actions / shellcheck succeeded Aug 19, 2024 in 0s

reviewdog [shellcheck] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (29)

e2e-tests/vars.sh|8 col 32| test_name is referenced but not assigned.
e2e-tests/vars.sh|25 col 1| date appears unused. Verify use (or export if used externally).
build/ps-entrypoint.sh|61 col 6| ShellCheck can't follow non-constant source. Use a directive to specify location.
build/ps-entrypoint.sh|200 col 22| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/ps-entrypoint.sh|216 col 34| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/ps-entrypoint.sh|216 col 70| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/ps-entrypoint.sh|274 col 30| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/ps-entrypoint.sh|356 col 22| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/ps-entrypoint.sh|404 col 2| cluster_name appears unused. Verify use (or export if used externally).
build/binlog-server-entrypoint.sh|5 col 6| Double quote array expansions to avoid re-splitting elements.
build/haproxy_check_replicas.sh|27 col 28| Prefer mapfile or read -a to split command output (or quote to avoid splitting).
build/haproxy_check_replicas.sh|27 col 35| Double quote to prevent globbing and word splitting.
build/haproxy_check_replicas.sh|47 col 28| Prefer mapfile or read -a to split command output (or quote to avoid splitting).
build/haproxy_check_replicas.sh|47 col 35| Double quote to prevent globbing and word splitting.
build/run-backup.sh|63 col 26| Want to escape a single quote? echo 'This is how it'''s done'.
build/run-backup.sh|63 col 31| Want to escape a single quote? echo 'This is how it'''s done'.
build/router_startup_check.sh|5 col 68| This { is literal. Check expression (missing ;/\n?) or quote it.
build/router_startup_check.sh|5 col 78| This } is literal. Check expression (missing ;/\n?) or quote it.
build/heartbeat-entrypoint.sh|24 col 40| Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
build/haproxy-entrypoint.sh|30 col 26| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/haproxy-entrypoint.sh|43 col 11| Double quote to prevent globbing and word splitting.
build/router-entrypoint.sh|20 col 6| Double quote to prevent globbing and word splitting.
build/router-entrypoint.sh|20 col 74| Double quote to prevent globbing and word splitting.
build/haproxy_check_primary.sh|27 col 28| Prefer mapfile or read -a to split command output (or quote to avoid splitting).
build/haproxy_check_primary.sh|27 col 35| Double quote to prevent globbing and word splitting.
build/haproxy_check_primary.sh|47 col 28| Prefer mapfile or read -a to split command output (or quote to avoid splitting).
build/haproxy_check_primary.sh|47 col 35| Double quote to prevent globbing and word splitting.
build/haproxy_add_mysql_nodes.sh|25 col 8| read without -r will mangle backslashes.
build/haproxy_add_mysql_nodes.sh|54 col 2| Consider using { cmd1; cmd2; } >> file instead of individual redirects.