K8SPS-204: don't depend on orchestrator for topology discovery #1679
reviewdog [shellcheck] report
reported by reviewdog 🐶
Findings (2)
build/haproxy_add_mysql_nodes.sh|25 col 8| read without -r will mangle backslashes.
build/haproxy_add_mysql_nodes.sh|49 col 2| Consider using { cmd1; cmd2; } >> file instead of individual redirects.
Filtered Findings (13)
e2e-tests/vars.sh|25 col 1| date appears unused. Verify use (or export if used externally).
build/haproxy-entrypoint.sh|14 col 11| Double quote to prevent globbing and word splitting.
build/heartbeat-entrypoint.sh|24 col 40| Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
build/router-entrypoint.sh|20 col 6| Double quote to prevent globbing and word splitting.
build/router-entrypoint.sh|20 col 74| Double quote to prevent globbing and word splitting.
build/ps-entrypoint.sh|61 col 6| ShellCheck can't follow non-constant source. Use a directive to specify location.
build/ps-entrypoint.sh|194 col 22| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/ps-entrypoint.sh|210 col 34| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/ps-entrypoint.sh|210 col 70| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/ps-entrypoint.sh|268 col 30| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/ps-entrypoint.sh|350 col 22| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/run-backup.sh|61 col 26| Want to escape a single quote? echo 'This is how it'''s done'.
build/run-backup.sh|61 col 31| Want to escape a single quote? echo 'This is how it'''s done'.
Annotations
Check notice on line 25 in build/haproxy_add_mysql_nodes.sh
github-actions / shellcheck
[shellcheck] build/haproxy_add_mysql_nodes.sh#L25 <ShellCheck.SC2162>
read without -r will mangle backslashes.
Raw output
./build/haproxy_add_mysql_nodes.sh:25:8: info: read without -r will mangle backslashes. (ShellCheck.SC2162)
Check notice on line 49 in build/haproxy_add_mysql_nodes.sh
github-actions / shellcheck
[shellcheck] build/haproxy_add_mysql_nodes.sh#L49 <ShellCheck.SC2129>
Consider using { cmd1; cmd2; } >> file instead of individual redirects.
Raw output
./build/haproxy_add_mysql_nodes.sh:49:2: info: Consider using { cmd1; cmd2; } >> file instead of individual redirects. (ShellCheck.SC2129)