Skip to content

K8SPS-353: Deploy Binlog Server #2247

K8SPS-353: Deploy Binlog Server

K8SPS-353: Deploy Binlog Server #2247

GitHub Actions / shellcheck failed Aug 13, 2024 in 0s

reviewdog [shellcheck] report

reported by reviewdog 🐶

Findings (8)

build/ps-entrypoint.sh|61 col 6| ShellCheck can't follow non-constant source. Use a directive to specify location.
build/ps-entrypoint.sh|200 col 22| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/ps-entrypoint.sh|216 col 34| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/ps-entrypoint.sh|216 col 70| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/ps-entrypoint.sh|274 col 30| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/ps-entrypoint.sh|356 col 22| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/ps-entrypoint.sh|404 col 2| cluster_name appears unused. Verify use (or export if used externally).
build/binlog-server-entrypoint.sh|5 col 6| Double quote array expansions to avoid re-splitting elements.

Filtered Findings (21)

e2e-tests/vars.sh|8 col 32| test_name is referenced but not assigned.
e2e-tests/vars.sh|25 col 1| date appears unused. Verify use (or export if used externally).
build/haproxy_check_replicas.sh|27 col 28| Prefer mapfile or read -a to split command output (or quote to avoid splitting).
build/haproxy_check_replicas.sh|27 col 35| Double quote to prevent globbing and word splitting.
build/haproxy_check_replicas.sh|47 col 28| Prefer mapfile or read -a to split command output (or quote to avoid splitting).
build/haproxy_check_replicas.sh|47 col 35| Double quote to prevent globbing and word splitting.
build/run-backup.sh|63 col 26| Want to escape a single quote? echo 'This is how it'''s done'.
build/run-backup.sh|63 col 31| Want to escape a single quote? echo 'This is how it'''s done'.
build/router_startup_check.sh|5 col 68| This { is literal. Check expression (missing ;/\n?) or quote it.
build/router_startup_check.sh|5 col 78| This } is literal. Check expression (missing ;/\n?) or quote it.
build/heartbeat-entrypoint.sh|24 col 40| Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
build/haproxy-entrypoint.sh|30 col 26| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/haproxy-entrypoint.sh|43 col 11| Double quote to prevent globbing and word splitting.
build/router-entrypoint.sh|20 col 6| Double quote to prevent globbing and word splitting.
build/router-entrypoint.sh|20 col 74| Double quote to prevent globbing and word splitting.
build/haproxy_check_primary.sh|27 col 28| Prefer mapfile or read -a to split command output (or quote to avoid splitting).
build/haproxy_check_primary.sh|27 col 35| Double quote to prevent globbing and word splitting.
build/haproxy_check_primary.sh|47 col 28| Prefer mapfile or read -a to split command output (or quote to avoid splitting).
build/haproxy_check_primary.sh|47 col 35| Double quote to prevent globbing and word splitting.
build/haproxy_add_mysql_nodes.sh|25 col 8| read without -r will mangle backslashes.
build/haproxy_add_mysql_nodes.sh|54 col 2| Consider using { cmd1; cmd2; } >> file instead of individual redirects.

Annotations

Check warning on line 61 in build/ps-entrypoint.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] build/ps-entrypoint.sh#L61 <ShellCheck.SC1090>

ShellCheck can't follow non-constant source. Use a directive to specify location.
Raw output
./build/ps-entrypoint.sh:61:6: warning: ShellCheck can't follow non-constant source. Use a directive to specify location. (ShellCheck.SC1090)

Check warning on line 200 in build/ps-entrypoint.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] build/ps-entrypoint.sh#L200 <ShellCheck.SC2166>

Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
Raw output
./build/ps-entrypoint.sh:200:22: warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. (ShellCheck.SC2166)

Check warning on line 216 in build/ps-entrypoint.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] build/ps-entrypoint.sh#L216 <ShellCheck.SC2166>

Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
Raw output
./build/ps-entrypoint.sh:216:34: warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. (ShellCheck.SC2166)

Check warning on line 216 in build/ps-entrypoint.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] build/ps-entrypoint.sh#L216 <ShellCheck.SC2166>

Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
Raw output
./build/ps-entrypoint.sh:216:70: warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. (ShellCheck.SC2166)

Check warning on line 274 in build/ps-entrypoint.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] build/ps-entrypoint.sh#L274 <ShellCheck.SC2166>

Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
Raw output
./build/ps-entrypoint.sh:274:30: warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. (ShellCheck.SC2166)

Check warning on line 356 in build/ps-entrypoint.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] build/ps-entrypoint.sh#L356 <ShellCheck.SC2166>

Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
Raw output
./build/ps-entrypoint.sh:356:22: warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. (ShellCheck.SC2166)

Check warning on line 404 in build/ps-entrypoint.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] build/ps-entrypoint.sh#L404 <ShellCheck.SC2034>

cluster_name appears unused. Verify use (or export if used externally).
Raw output
./build/ps-entrypoint.sh:404:2: warning: cluster_name appears unused. Verify use (or export if used externally). (ShellCheck.SC2034)

Check failure on line 5 in build/binlog-server-entrypoint.sh

See this annotation in the file changed.

@github-actions github-actions / shellcheck

[shellcheck] build/binlog-server-entrypoint.sh#L5 <ShellCheck.SC2068>

Double quote array expansions to avoid re-splitting elements.
Raw output
./build/binlog-server-entrypoint.sh:5:6: error: Double quote array expansions to avoid re-splitting elements. (ShellCheck.SC2068)