-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GITHUB-ISSUE-1810: Fix newline in last set filename #1811
Merged
hors
merged 4 commits into
percona:main
from
dcaputo-harmoni:GITHUB-ISSUE-1810-fix-pitr-newline-in-filename
Oct 1, 2024
Merged
GITHUB-ISSUE-1810: Fix newline in last set filename #1811
hors
merged 4 commits into
percona:main
from
dcaputo-harmoni:GITHUB-ISSUE-1810-fix-pitr-newline-in-filename
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ause it applies to all storage types
dcaputo-harmoni
requested review from
hors,
egegunes,
inelpandzic and
pooknull
as code owners
September 1, 2024 02:49
Fixes #1810 |
dcaputo-harmoni
changed the title
Fix newline in last set filename
GITHUB-ISSUE-1810: Fix newline in last set filename
Sep 1, 2024
egegunes
approved these changes
Sep 27, 2024
@dcaputo-harmoni thank you for your contribution. @inelpandzic could you please review as well? |
inelpandzic
approved these changes
Sep 30, 2024
commit: fd7d230 |
@dcaputo-harmoni Thank you for contribution. We will include this fix in the next PXCO release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes minor change to "s3" reference in collector logging (changed to "storage") because the push applies to all storage types. See github issue 1810 for details on the newline issue that is addressed in this commit.