Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GITHUB-ISSUE-1810: Fix newline in last set filename #1811

Conversation

dcaputo-harmoni
Copy link
Contributor

Also includes minor change to "s3" reference in collector logging (changed to "storage") because the push applies to all storage types. See github issue 1810 for details on the newline issue that is addressed in this commit.

@CLAassistant
Copy link

CLAassistant commented Sep 1, 2024

CLA assistant check
All committers have signed the CLA.

@dcaputo-harmoni
Copy link
Contributor Author

Fixes #1810

@dcaputo-harmoni dcaputo-harmoni changed the title Fix newline in last set filename GITHUB-ISSUE-1810: Fix newline in last set filename Sep 1, 2024
@hors hors added the community label Sep 5, 2024
@egegunes
Copy link
Contributor

@dcaputo-harmoni thank you for your contribution.

@inelpandzic could you please review as well?

@JNKPercona
Copy link
Collaborator

Test name Status
affinity-8-0 passed
auto-tuning-8-0 passed
cross-site-8-0 passed
demand-backup-cloud-8-0 passed
demand-backup-encrypted-with-tls-8-0 passed
demand-backup-8-0 passed
haproxy-5-7 passed
haproxy-8-0 passed
init-deploy-5-7 passed
init-deploy-8-0 passed
limits-8-0 passed
monitoring-2-0-8-0 passed
one-pod-5-7 passed
one-pod-8-0 passed
pitr-8-0 passed
pitr-gap-errors-8-0 passed
proxy-protocol-8-0 passed
proxysql-sidecar-res-limits-8-0 passed
pvc-resize-5-7 passed
pvc-resize-8-0 passed
recreate-8-0 passed
restore-to-encrypted-cluster-8-0 passed
scaling-proxysql-8-0 passed
scaling-8-0 passed
scheduled-backup-5-7 passed
scheduled-backup-8-0 passed
security-context-8-0 passed
smart-update1-8-0 passed
smart-update2-8-0 passed
storage-8-0 passed
tls-issue-cert-manager-ref-8-0 passed
tls-issue-cert-manager-8-0 passed
tls-issue-self-8-0 passed
upgrade-consistency-8-0 passed
upgrade-haproxy-5-7 passed
upgrade-haproxy-8-0 passed
upgrade-proxysql-5-7 passed
upgrade-proxysql-8-0 passed
users-5-7 passed
users-8-0 passed
validation-hook-8-0 passed
We run 41 out of 41

commit: fd7d230
image: perconalab/percona-xtradb-cluster-operator:PR-1811-fd7d230e

@hors hors merged commit 4432542 into percona:main Oct 1, 2024
13 checks passed
@hors
Copy link
Collaborator

hors commented Oct 1, 2024

@dcaputo-harmoni Thank you for contribution. We will include this fix in the next PXCO release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants