-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPXC-1155: Fix stuck smart update after invalid configuration #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egegunes
requested review from
hors,
inelpandzic and
pooknull
as code owners
September 29, 2024 11:41
inelpandzic
approved these changes
Sep 30, 2024
nmarukovich
approved these changes
Oct 2, 2024
commit: ea892c3 |
pooknull
approved these changes
Oct 8, 2024
s10
pushed a commit
to s10/percona-xtradb-cluster-operator
that referenced
this pull request
Oct 25, 2024
…ona#1829) * K8SPXC-1155: Fix stuck smart update after invalid configuration * fix S1012 --------- Co-authored-by: Viacheslav Sarzhan <[email protected]> Co-authored-by: Natalia Marukovich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
If user applies a config which causes pods fail to schedule, they can't fix it by applying corrected configuration because operator rejects to start smart update if not all PXC pods are ready.
Solution:
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability