Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPXC-1155: Fix stuck smart update after invalid configuration #1829

Merged
merged 6 commits into from
Oct 8, 2024

Conversation

egegunes
Copy link
Contributor

@egegunes egegunes commented Sep 25, 2024

K8SPXC-1155 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
If user applies a config which causes pods fail to schedule, they can't fix it by applying corrected configuration because operator rejects to start smart update if not all PXC pods are ready.

Solution:

  • This PR removes the check to wait for all PXC pods be ready before smart update.
  • If pods fail to schedule, operator retries to smart update for 2 hours by default. This is very long to fail smart updated. After these changes, if a pod is failed to schedule for 2 minutes operator will fail the smart update and return an error.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PXC version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/M 30-99 lines label Sep 25, 2024
@egegunes egegunes marked this pull request as ready for review September 29, 2024 11:41
@JNKPercona
Copy link
Collaborator

Test name Status
affinity-8-0 passed
auto-tuning-8-0 passed
cross-site-8-0 passed
demand-backup-cloud-8-0 passed
demand-backup-encrypted-with-tls-8-0 passed
demand-backup-8-0 passed
haproxy-5-7 passed
haproxy-8-0 passed
init-deploy-5-7 passed
init-deploy-8-0 passed
limits-8-0 passed
monitoring-2-0-8-0 passed
one-pod-5-7 passed
one-pod-8-0 passed
pitr-8-0 passed
pitr-gap-errors-8-0 passed
proxy-protocol-8-0 passed
proxysql-sidecar-res-limits-8-0 passed
pvc-resize-5-7 passed
pvc-resize-8-0 passed
recreate-8-0 passed
restore-to-encrypted-cluster-8-0 passed
scaling-proxysql-8-0 passed
scaling-8-0 passed
scheduled-backup-5-7 passed
scheduled-backup-8-0 passed
security-context-8-0 passed
smart-update1-8-0 passed
smart-update2-8-0 passed
storage-8-0 passed
tls-issue-cert-manager-ref-8-0 passed
tls-issue-cert-manager-8-0 passed
tls-issue-self-8-0 passed
upgrade-consistency-8-0 passed
upgrade-haproxy-5-7 passed
upgrade-haproxy-8-0 passed
upgrade-proxysql-5-7 passed
upgrade-proxysql-8-0 passed
users-5-7 passed
users-8-0 passed
validation-hook-8-0 passed
We run 41 out of 41

commit: ea892c3
image: perconalab/percona-xtradb-cluster-operator:PR-1829-ea892c39

@hors hors merged commit eab9932 into main Oct 8, 2024
16 checks passed
@hors hors deleted the K8SPXC-1155 branch October 8, 2024 14:50
s10 pushed a commit to s10/percona-xtradb-cluster-operator that referenced this pull request Oct 25, 2024
…ona#1829)

* K8SPXC-1155: Fix stuck smart update after invalid configuration

* fix S1012

---------

Co-authored-by: Viacheslav Sarzhan <[email protected]>
Co-authored-by: Natalia Marukovich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M 30-99 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants