Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format sources #475

Merged
merged 23 commits into from
Aug 7, 2024
Merged

Format sources #475

merged 23 commits into from
Aug 7, 2024

Conversation

artemgavrilov
Copy link
Contributor

@artemgavrilov artemgavrilov commented Jul 17, 2024

This PR adds Makefile targets that format sources according to PG rules and CI workflow that checks that opened pull request has formatted sources (CI fails if sources are not formatted).

https://wiki.postgresql.org/wiki/Running_pgindent_on_non-core_code_or_development_code
https://github.com/postgres/postgres/blob/master/src/tools/pgindent/README

@artemgavrilov artemgavrilov changed the title Code formatting Format sources Jul 17, 2024
@artemgavrilov artemgavrilov marked this pull request as ready for review July 17, 2024 16:59
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.87%. Comparing base (1aa3081) to head (d5b73bc).
Report is 1 commits behind head on main.

Files Patch % Lines
pg_stat_monitor.c 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
- Coverage   84.98%   84.87%   -0.11%     
==========================================
  Files           3        3              
  Lines        1292     1296       +4     
  Branches      197      198       +1     
==========================================
+ Hits         1098     1100       +2     
  Misses         98       98              
- Partials       96       98       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@darkfronza darkfronza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artemgavrilov artemgavrilov merged commit 3bb6579 into main Aug 7, 2024
25 of 28 checks passed
@artemgavrilov artemgavrilov deleted the code-formatting branch August 7, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants