PMM-12899 fix "build_command" extrapolation

percona · Nov 5, 2024 · 45fd300 · 45fd300
1 parent 93d5d7c
commit 45fd300
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/admin/Makefile b/admin/Makefile
@@ -13,7 +13,7 @@ PMM_RELEASE_FULLCOMMIT ?= $(shell git rev-parse HEAD)
 PMM_RELEASE_BRANCH ?= $(shell git describe --always --contains --all)
 
 ifdef NO_VCS
-	NO_VCS := -buildvcs=false
+	NO_VCS = -buildvcs=false
 endif
 ifeq ($(GOBIN),)
 	GOBIN := $(shell go env GOPATH)/bin

diff --git a/agent/Makefile b/agent/Makefile
@@ -14,7 +14,7 @@ PMM_RELEASE_BRANCH ?= $(shell git describe --always --contains --all)
 PMM_DEV_SERVER_PORT ?= 8443
 
 ifdef NO_VCS
-	NO_VCS := -buildvcs=false
+	NO_VCS = -buildvcs=false
 endif
 ifeq ($(GOBIN),)
 	GOBIN := $(shell go env GOPATH)/bin

diff --git a/build/scripts/build-client-binary b/build/scripts/build-client-binary
@@ -83,7 +83,7 @@ gobuild_component() {
 
         tar -C /tmp/go/src/${extract_path} --strip-components=1 -zxpf ${src_dir}/${archive}
 
-        ${build_command}
+        "${build_command}"
     "
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -83,7 +83,7 @@ gobuild_component() { @@
             tar -C /tmp/go/src/${extract_path} --strip-components=1 -zxpf ${src_dir}/${archive}
-            ${build_command}
+            "${build_command}"
         "
     }
@@ Expand Down @@