PMM-12593 Run grafana renderer to render images. #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BupycHuk
requested review from
idoqo and
JiriCtvrtka
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #3232 +/- ##
=======================================
Coverage 43.45% 43.45%
=======================================
Files 360 360
Lines 43979 43979
=======================================
Hits 19109 19109
Misses 23208 23208
Partials 1662 1662
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
idoqo
approved these changes
Oct 10, 2024
| @@ -37,6 +37,8 @@ format = console | |||
| enable_gzip = true | |||
| # The full public facing url | |||
| root_url = https://%(domain)s/graph | |||
| # Serve Grafana from subpath specified in `root_url` setting. By default it is set to false for compatibility reasons. | |||
There was a problem hiding this comment.
Out of curiosity: What was the compatibility reason though (is it with older PMM version?) and do we need to mention it here?
JiriCtvrtka
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12593
Link to the Feature Build: SUBMODULES-3729
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: