Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13413 Do not run pillars telemetry #3264

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Oct 23, 2024

PMM-13413

Link to the Feature Build: SUBMODULES-3744

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 43.44%. Comparing base (43cc6db) to head (ab439f6).

Files with missing lines Patch % Lines
managed/utils/envvars/parser.go 50.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##               v3    #3264   +/-   ##
=======================================
  Coverage   43.44%   43.44%           
=======================================
  Files         360      360           
  Lines       43979    43985    +6     
=======================================
+ Hits        19107    19110    +3     
- Misses      23210    23213    +3     
  Partials     1662     1662           
Flag Coverage Δ
admin 11.45% <ø> (ø)
agent 51.93% <ø> (ø)
managed 45.16% <50.00%> (+<0.01%) ⬆️
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff ademidoff marked this pull request as ready for review October 28, 2024 08:50
@ademidoff ademidoff requested a review from a team as a code owner October 28, 2024 08:50
@ademidoff ademidoff requested review from BupycHuk, idoqo and talhabinrizwan and removed request for a team October 28, 2024 08:50
@ademidoff ademidoff closed this Oct 29, 2024
@ademidoff ademidoff deleted the PMM-13413-disable-pg-telemetry branch October 29, 2024 10:39
@ademidoff ademidoff restored the PMM-13413-disable-pg-telemetry branch October 29, 2024 10:57
@ademidoff ademidoff reopened this Oct 29, 2024
@ademidoff ademidoff force-pushed the PMM-13413-disable-pg-telemetry branch from dc482d9 to 33779e8 Compare October 29, 2024 11:09
@ademidoff ademidoff requested review from a team and yurkovychv as code owners October 29, 2024 11:09
@ademidoff ademidoff requested review from BupycHuk and YashSartanpara1 and removed request for a team October 29, 2024 11:09
@ademidoff ademidoff changed the base branch from PMM-12641-optimize-pmm-build-scripts to v3 October 29, 2024 11:09
@ademidoff ademidoff changed the title PMM-13413 Do not install pg-telemetry package PMM-13413 Do not run pillars telemetry Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants