Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12593 Fix grafana renderer for PMM 2. #3270

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

BupycHuk
Copy link
Member

PMM-12593

Link to the Feature Build: SUBMODULES-3746

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@BupycHuk BupycHuk requested review from talhabinrizwan and a team as code owners October 28, 2024 13:46
@BupycHuk BupycHuk requested review from idoqo and JiriCtvrtka and removed request for a team October 28, 2024 13:46
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.06%. Comparing base (7cdb659) to head (868cb40).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3270      +/-   ##
==========================================
- Coverage   43.25%   42.06%   -1.19%     
==========================================
  Files         399      399              
  Lines       41725    50722    +8997     
==========================================
+ Hits        18047    21337    +3290     
- Misses      21669    27374    +5705     
- Partials     2009     2011       +2     
Flag Coverage Δ
admin 11.55% <ø> (-0.07%) ⬇️
agent 51.98% <ø> (-0.27%) ⬇️
managed 42.78% <ø> (-1.66%) ⬇️
vmproxy 68.57% <ø> (+1.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BupycHuk BupycHuk enabled auto-merge (squash) October 28, 2024 13:55
@BupycHuk BupycHuk merged commit 948e93e into main Oct 28, 2024
29 of 31 checks passed
@BupycHuk BupycHuk deleted the PMM-12593-run-grafana-renderer-for-pmm2 branch October 28, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants