Indentation check CI and helper scripts #32
Conversation
dutow
changed the title
dutow
force-pushed
the
indentfix
branch
6 times, most recently
from
281ad6c to
20ac5fd
Compare
There was a problem hiding this comment.
I feel this MR should be split in two, the third commit does not really belong unless I misunderstand things, plus that the first commit should be a pure re-indent run and not contain other things like it does now.
Also ssaw that some of your files does not end in newline.
.scripts/make-test.sh
Outdated
|
|
||
|
|
||
| EXTRA_REGRESS_OPTS="--extra-setup=$SCRIPT_DIR/tde_setup.sql --load-extension=pg_tde" make installcheck-world -k |
There was a problem hiding this comment.
This file should end with a newline.
| contrib/pg_tde/src16/.* | ||
| contrib/pg_tde/src17.* | ||
| contrib/pg_tde/src/libkmip/.* | ||
| src/backend/nodes/nodetags.h |
There was a problem hiding this comment.
This file should end with a newline.
.scripts/make-build.sh
Outdated
| ./configure --enable-debug --enable-cassert --enable-tap-tests --prefix=$INSTALL_DIR | ||
| make install-world |
There was a problem hiding this comment.
Missing newline at end of file.
.github/workflows/pgindent.yml
Outdated
|
|
||
| - name: Run pgindent | ||
| run: src/.scripts/run-pgindent.sh --check --diff | ||
|
|
There was a problem hiding this comment.
Missing newline at end of file.
src/backend/access/table/tableam.c
Outdated
| } | ||
|
|
There was a problem hiding this comment.
Why is this file changed in this commit? It should probably be changed in its own commit.
| } | ||
|
|
There was a problem hiding this comment.
Why is this file changed in this commit? It should probably be changed in its own commit.
| contrib/pg_tde/src16/.* | ||
| contrib/pg_tde/src17.* |
There was a problem hiding this comment.
does it make sense do have something like
contrib/pg_tde/src1.*
or
contrib/pg_tde/src[0-9].*
so no need to update it with PG v18 and so on
There was a problem hiding this comment.
Yeah, maybe, but this is temporary as we plan to remove these completely after the next release, so it's only for a few weeks.
dutow
force-pushed
the
indentfix
branch
3 times, most recently
from
ec4b664 to
33b4c9e
Compare
This pull request adds indnetation checks on a github action, and helper scripts which can be used to run pgindent easily locally.
There are two scripts:
The entire source tree is also reformatted using this script.
Since my other PR also contains source code changes, this PR is based on that. Only the last 2 commits are actually part of this PR, please only review those as part of this.