Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in one versions of pg_tde_change_key_provider_kmip() #40

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

jeltz
Copy link
Collaborator

@jeltz jeltz commented Feb 4, 2025

There was a copy pasto in one of the arguments.

@dutow @dAdAbird Should we add a test case for this because apparently there was no coverage of this function?

Copy link
Collaborator

@dutow dutow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, test coverage generally is low, we'll have to improve that.

There was a copy pasto in one of the arguments.
@jeltz jeltz force-pushed the change-key-kmip-typo branch from d8344b0 to 78c8e5d Compare February 4, 2025 16:56
@jeltz jeltz closed this Feb 5, 2025
@jeltz jeltz reopened this Feb 5, 2025
@jeltz jeltz merged commit 11a05ca into percona:TDE_REL_17_STABLE Feb 5, 2025
14 of 18 checks passed
@jeltz jeltz deleted the change-key-kmip-typo branch February 7, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants