PG-1258: Implement pg_tde_verify_principal_key functions #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutow
force-pushed
the
pg1258
branch
2 times, most recently
from
a99eda3 to
5a18e58
Compare
These functions allow users to check if the keyring is accessible, and if it still returns the same key as stored in memory for the server.
jeltz
requested changes
Feb 6, 2025
|
@jeltz There's a basic test for both the successful and failing case with the file provider. This is a simple function, that's all it is to it. I added it to the existing key_provider test suite, as this function sanity checks the configuration of a key provider. Constructing a testcase for the other failing case ("Key returned by keyring and cached in pg_tde is different") would be a bit more complex, as that's not something that could realistically happen in a real world situation. I could force a test for it with the file keyring, but that would be a bit of a hack. |
|
Would have preferred a failing test but your call. |
jeltz
approved these changes
Feb 7, 2025
|
Ignore my last emssage, somehow I missed the failing case. My apologies. Still approved of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions allow users to check if the keyring is accessible, and if it still returns the same key as stored in memory for the server.
Review note: PR is based on my previous PR, only the last commit is new.