Clean up the grant/revoke functions #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeltz
force-pushed
the
clean-grant-revoke
branch
from
cb4d179 to
311747b
Compare
dutow
approved these changes
Feb 7, 2025
jeltz
force-pushed
the
clean-grant-revoke
branch
from
311747b to
9a41b26
Compare
This code does not do anything with the exceptions other than re-throwing them so why catch them in the first place?
Users might assume that the return value means something when it does not.
Since a user is just a role which can log in it we can replace "user_or_role" with just "role".
The code becaomes shorter and easier to understand without the wrapper functions and two less functions in the namespace is a nice bonus.
jeltz
force-pushed
the
clean-grant-revoke
branch
from
9a41b26 to
2dbbe7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the functions I wondered if it would not be easier to read them if they just ran
EXECUTE format(...)directly instead of using helper functions which pollute the namespace. What do you say?