Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating the extension in another schema was broken.
This PR fixes the issue by using
BEGIN ATOMIC
for SQL functions and setting thesearch_path
for plpgsql functions. But since the plpgsql functions are not reloctable we setrelocatable = false
in the extension control file. If we want to make the extension relocatable I propose we do it as a separate PR.I also did some style fixes which you are free to object to. They are as a separate commit so that can be dropped or changed if you do not like it.