PG-1222 Fix bug where we confuse relations with the same RelFileNumber in different databases #60
+61
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same comment is also at GetRelationKey() where it should be.
Removes an unnecessary level of indirection which simplifies the code and in theory should give a miniscule perfomrance improvement. While at it we also remove a usless NULL check which could never happen plus move at variable declaration to another scope.
This fixes a bug where if the same RelFileNumber was used in two databases we could confuse the two relations and use the wrong key, which could result in a corrupted database.
Instead of recalculating the path when we get an error we just pass it along to the function. Less code and more correct.
Since the maps on file are per database and only store the RelFileNumber it is confusing if we pass the whole locator to these functions. This is unlike the in-memory cache which is shared between all databases so the keys need to be both database oid and RelFileNumber.
|
|
dutow
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bug PG-1222 which was caused by the relation key cache only having the RelFileNumber as key when looking up relations. The RelFileNumber is only unique per database. On the other hand we did not have the same bug with keys stored on disk since there we used one file per database so there I instead refactored the code to make it more obvious that is what we are doing.
While at it I also removed a layer of indirection in to
tde_re_file_cacheto simplify the code.