-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPLT_3672: [Smart concurrency] Scaling up/down asset discovery queue #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: minor code bugs && will continue with that
prklm10
reviewed
Jan 24, 2025
prklm10
reviewed
Jan 24, 2025
ninadbstack
reviewed
Jan 24, 2025
ninadbstack
reviewed
Jan 24, 2025
ninadbstack
reviewed
Jan 24, 2025
ninadbstack
reviewed
Jan 24, 2025
ninadbstack
reviewed
Jan 24, 2025
ninadbstack
reviewed
Jan 24, 2025
test: added tests for the smae for every module in monitoring
prklm10
reviewed
Jan 27, 2025
prklm10
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. 🍍 Please share the QA plan.
ninadbstack
reviewed
Jan 27, 2025
ninadbstack
reviewed
Jan 27, 2025
ninadbstack
approved these changes
Jan 27, 2025
Amit3200
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Changes:
start()
-> when percy cli is started. start system metricsstarts monitoring
if monitoring was stopped due to inactivity on clistop()
-> stop monitoring if not already stoppedClient info collection details
New package used
systeminformation
: This was done as in macOSX, we had observed at osx, allocated large chunk of memory as buffer cache and not use it, but while getting used memory it also gets included in that. This package helps and handles are those cases for different cpu arch and osCertain assumptions
What is left ?
Dev Testing:
QA Testing: