Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly name initial branch in tests #119

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Explicitly name initial branch in tests #119

merged 2 commits into from
Nov 2, 2023

Conversation

viktordick
Copy link
Collaborator

For systems that have init.defaultBranch set globally

@viktordick
Copy link
Collaborator Author

Builds on top of #116 because I plan to merge that one first

@viktordick viktordick changed the base branch from drop-py2 to master September 30, 2023 07:26
gandie
gandie requested changes Sep 30, 2023
View reviewed changes
Copy link
Member

@gandie gandie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer a name like autotest to avoid confusion and show the intention of the branch. Maybe it is also wise to store this name in a variable, e.g. as attribute of the repository instance created for tests.

Viktor Dick added 2 commits October 11, 2023 19:56
Explicitly name initial branch in tests
58e56aa 
For systems that have init.defaultBranch set globally
Change branch name
3d4314f
gandie
gandie approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@gandie gandie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@viktordick viktordick merged commit 36b0a58 into master Nov 2, 2023
3 checks passed
@viktordick viktordick deleted the explicit-branch-name branch November 2, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandie gandie gandie approved these changes

Assignees

@jan-jockusch jan-jockusch

@Wiseqube Wiseqube

@gandie gandie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viktordick @gandie @jan-jockusch @Wiseqube