-
-
Notifications
You must be signed in to change notification settings - Fork 247
Draft: macOS Build system updates #2274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tallpsmith
wants to merge
102
commits into
performancecopilot:main
Choose a base branch
from
tallpsmith:osxbuild
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rchy and everything is right here in the current directory.
…pcp to verbose mode for local testing.
…t install on OSX because of /usr/lib.
…hat breaks the subsequent mv attempt when it's no there anymore.
…(and at least one isn't complete somehow locally).
…cp/summary) before attempting to install the file. Really not sure why this isn't broken on OTHER systems.. ?
…cp/summary) before attempting to install the file. Really not sure why this isn't broken on OTHER systems.. ?
…e CP worked, but the ELSE condition holds in a 'clean' install and tried to MV, so fails.
…per (into /private), so these symlink creations don't _quite_ go up enough in the traversal causing the relative symlinkes to fail. Hacky == true.
…ce with LaunchCTL (attempt)
…ce with LaunchCTL (attempt)
…h will exit cleanly after launching the process (so it's not really a proper 'daemon' per-se, and send some launchctl logs somewhere so I can see them. Do not look at the typo, nothing to see here.
…teh original OSX Startup stuff is gone and this was always a clone anyawy)
…re-linking so that pmrep can work.
…quired environment to build the macOS bundles & distribution.
…teh original OSX Startup stuff is gone and this was always a clone anyawy)
…re-linking so that pmrep can work.
…quired environment to build the macOS bundles & distribution.
…s to the workflow console.
…e python re-install and python environment debugging
… MADIRECTORYHACK method...
… than my MADIRECTORYHACK method..." This reverts commit 7cddc4a.
… fixed python path at the moment)
… to the Homebrew python if its been installed. If not, the header files won't be there but it'll keep going.
… for postinstall library remapping. This makes it safer if different python3 versions are used on systems. e.g. not quite as much of a dirty hack as it was before.
…ything work before, crossfingers...
…ything work before, crossfingers...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings macOS back to PCP.
pkgbuild
to create the installation packaging. This requires removal of some previously supported installation hooks.pmcd
are done, migrating to LaunchCTL based systemWorks towards fixing #794