Support for sh1106 display. #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taken from https://github.com/sztanpet/sh1106 Dependencies updated.
maruel
reviewed
Apr 18, 2022
There was a problem hiding this comment.
Apologies for the delay, I was travelling.
I'll check later why go1.18 is used in the CI; I know that gosec is not yet compatible.
I'll have to checkout and diff with the other driver to see the difference. It'd be nice to not duplicate code but it's not a big deal.
There's no doc nor tests.
| @@ -0,0 +1,484 @@ | |||
| // Copied almost verbatim from https://github.com/google/periph/tree/master/devices/ssd1306 | |||
There was a problem hiding this comment.
Shouldn't it be https://github.com/periph/devices/tree/main/ssd1306 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from:
https://github.com/sztanpet/sh1106
Which itself is mostly taken from
ssd1306/ssd1306.go.I only updated the dependencies to point to the new locations.