Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AHT20 tests #70

Merged
merged 9 commits into from
Jan 16, 2024
Merged

Add AHT20 tests #70

merged 9 commits into from
Jan 16, 2024

Conversation

SoulKa
Copy link
Contributor

@SoulKa SoulKa commented Jan 16, 2024

  • Add tests for all exported methods of the AHT20 device (except SenseContinuous())
  • Fix IsInitialized() always returning false due to data byte not being set

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e644b7c) 61.6% compared to head (e5f433a) 61.4%.

Files Patch % Lines
aht20/aht20.go 57.1% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #70     +/-   ##
=======================================
- Coverage   61.6%   61.4%   -0.2%     
=======================================
  Files         65      67      +2     
  Lines       7442    7567    +125     
=======================================
+ Hits        4583    4646     +63     
- Misses      2705    2758     +53     
- Partials     154     163      +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maruel
Copy link
Member

maruel commented Jan 16, 2024

Thanks! If you want one optional thing that is sweet is to add an example that can be copy pasted by using package aht20_test. See other example files for an example and the corresponding generated doc.

@maruel maruel merged commit 872d025 into periph:main Jan 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants